[ 
https://issues.apache.org/jira/browse/THRIFT-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002332#comment-15002332
 ] 

Hudson commented on THRIFT-3415:
--------------------------------

SUCCESS: Integrated in Thrift #1721 (See 
[https://builds.apache.org/job/Thrift/1721/])
THRIFT-3415 - C++: THeader*.h/cpp includes cleanup (hcorg: rev 
517aa1491b1e16c88d17d6d83dcc7ef83bc85164)
* lib/cpp/src/thrift/protocol/THeaderProtocol.cpp
* lib/cpp/src/thrift/protocol/THeaderProtocol.h
* lib/cpp/src/thrift/transport/THeaderTransport.h
* lib/cpp/src/thrift/transport/THeaderTransport.cpp


> include unistd.h conditionally
> ------------------------------
>
>                 Key: THRIFT-3415
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3415
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.4
>            Reporter: Pascal Bach
>            Assignee: Konrad Grochowski
>             Fix For: 0.9.4
>
>         Attachments: unistd_include.patch
>
>
> THeaderTransport.h includes unistd.h unconidionaly.
> This breaks on non posix systems.
> The solution is to include it only when the corresponding define is set, like 
> it is done in the rest of the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to