[
https://issues.apache.org/jira/browse/THRIFT-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004283#comment-15004283
]
ASF GitHub Bot commented on THRIFT-3422:
----------------------------------------
GitHub user msonnabaum opened a pull request:
https://github.com/apache/thrift/pull/692
THRIFT-3422 Fixed Go's TServerSocket not closing socket on Interrupt.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/msonnabaum/thrift go-socket-not-closing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/692.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #692
----
commit 8fdcbade6436f4c3728f0d479e8e7596ec239a96
Author: Mark Sonnabaum <m...@sonnabaum.com>
Date: 2015-11-13T16:48:25Z
THRIFT-3422 Fixed Go's TServerSocket not closing socket on Interrupt.
----
> Go TServerSocket doesn't close on Interrupt
> -------------------------------------------
>
> Key: THRIFT-3422
> URL: https://issues.apache.org/jira/browse/THRIFT-3422
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.3
> Reporter: Mark Sonnabaum
>
> When using the Go version of TSimpleServer with a TServerSocket, I expected
> that calling Stop() would close the socket, but it does not. I discovered
> this in my test suite when I had to assign new port numbers to each test
> because otherwise they would fail to rebind.
> TSimpleServer.Stop calls TServerSocket.Interrupt, which is where I believe
> the issue lies. The java version's interrupt method calls close, so this
> seems to be the expected behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
