[ 
https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005820#comment-15005820
 ] 

Adam Beberg commented on THRIFT-3200:
-------------------------------------

I'd close this ticket. You've addressed the issue, and now it's compatible with 
the other languages, thank you! There is still a massive WinXP install base in 
Asia, but if someone needs the IE < 10 support they can add it under a new 
ticket and your test framework will make that simple.

> JS and nodejs do not encode JSON protocol binary fields as base64
> -----------------------------------------------------------------
>
>                 Key: THRIFT-3200
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3200
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 0.9.2
>            Reporter: Adam Beberg
>            Assignee: Aki Sukegawa
>             Fix For: 1.0
>
>
> Binary fields in the JSON protocol are base64 encoded in 
> cpp/go/java/rb/py/go/... All code with JSON implementations except javascript 
> and nodejs - which escape them as if they as strings (unfinished 
> implementation). This makes js/nodejs incompatable with any other languages 
> since JSON is their only supported protocol. To fix this js/nodejs need to be 
> corrected, but this will break backward compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to