[
https://issues.apache.org/jira/browse/THRIFT-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018325#comment-15018325
]
ASF GitHub Bot commented on THRIFT-3434:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/706
THRIFT-3434 Produce a reasonable name for includes in Dart generator
Use the namespace, if available, then the file name. Previously the Dart
generator was producing an empty string when a namespace was not provided.
https://issues.apache.org/jira/browse/THRIFT-3434
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift
thrift-3434_fix_include_names
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #706
----
commit 61300245862f4fc9f8b3bd8cf54f2efb8d1a8a07
Author: Mark Erickson <[email protected]>
Date: 2015-11-19T23:58:28Z
Produce a reasonable name for includes, using the namespace, if available,
then the file name. Previously it was producing an empty string when a
namespace was not provided.
https://issues.apache.org/jira/browse/THRIFT-3434
commit d28e2e994bed1eef1f9c4c8069ab93149320fc63
Author: Mark Erickson <[email protected]>
Date: 2015-11-20T03:27:05Z
Also replace dash character
https://issues.apache.org/jira/browse/THRIFT-3434
----
> Dart generator produces empty name in pubspec.yaml for includes without
> namespaces
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-3434
> URL: https://issues.apache.org/jira/browse/THRIFT-3434
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Compiler
> Reporter: Mark Erickson
> Assignee: Mark Erickson
>
> Given the following, the Dart generator produces a bad pubspec.yaml for
> example.thrift. It should reference "base", but instead uses an empty string.
> base.thrift
> {code}
> struct Foo {}
> {code}
> example.thrift
> {code}
> include "base.thrift"
> service FooService {
> base.Foo foo()
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
