Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-158567751
hm afaict that build failure is unrelated to my change:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/92019024/log.txt
Failure is:
```
clang++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift
-I/usr/include -I../../lib/cpp/src -Igen-cpp -Wall -Wextra -pedantic -g -O2
-std=c++11 -MT src/TestClient.o -MD -MP -MF $depbase.Tpo -c -o src/TestClient.o
src/TestClient.cpp &&\
mv -f $depbase.Tpo $depbase.Po
clang: error: unable to execute command: Killed
clang: error: clang frontend command failed due to signal (use -v to see
invocation)
clang version 3.4 (tags/RELEASE_34/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
clang: note: diagnostic msg: PLEASE submit a bug report to
http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and
associated run script.
depbase=`echo src/StressTest.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
clang++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift
-I/usr/include -I../../lib/cpp/src -Igen-cpp -Wall -Wextra -pedantic -g -O2
-std=c++11 -MT src/StressTest.o -MD -MP -MF $depbase.Tpo -c -o src/StressTest.o
src/StressTest.cpp &&\
mv -f $depbase.Tpo $depbase.Po
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
