[ https://issues.apache.org/jira/browse/THRIFT-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021182#comment-15021182 ]
Hudson commented on THRIFT-3431: -------------------------------- SUCCESS: Integrated in Thrift #1737 (See [https://builds.apache.org/job/Thrift/1737/]) THRIFT-3431 Avoid an unnecessary HashMap lookup (roger: rev 314fea26fe4d85d17d785d97f1e814fb448b82b9) * compiler/cpp/src/generate/t_java_generator.cc > Avoid "schemes" HashMap lookups during struct reads/writes > ---------------------------------------------------------- > > Key: THRIFT-3431 > URL: https://issues.apache.org/jira/browse/THRIFT-3431 > Project: Thrift > Issue Type: Improvement > Components: Java - Compiler > Affects Versions: 0.9.3 > Reporter: Tom Lee > Priority: Minor > > Generated Java code for structs doesn't need to do a HashMap lookup on every > read/write operation. > Was surprised to see this show up in profilers under certain high throughput, > write-heavy loads. Unclear if the cost was in the hashCode() implementation > of the key or in the map lookup itself, but given this map never changes, for > now it seems like it can be pretty safely replaced with a simple (and, in > most cases, predictable) branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)