[
https://issues.apache.org/jira/browse/THRIFT-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030327#comment-15030327
]
Roger Meier commented on THRIFT-3449:
-------------------------------------
Thanks for the patch!
Could you please create a *real* patch made by git diff or similar?
see CONTRIBUTING.md
> TBaseAsyncProcessor fb.responseReady() never called for oneway functions
> ------------------------------------------------------------------------
>
> Key: THRIFT-3449
> URL: https://issues.apache.org/jira/browse/THRIFT-3449
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.3
> Environment: java libthrift-0.9.3
> Reporter: Jan Sileny
> Labels: newbie, patch
> Fix For: 0.9.3
>
> Attachments: responseReadyPatch.patch
>
>
> For regular service functions, fb.responseReady() is called from generated
> AsyncProcessFunction's sendResponse(...). Precisely in its result handler's
> AsyncMethodCallback onComplete or onError implementations. Because oneway
> methods have void result handler's onComplete and onError implementations,
> responseReady is not called and frame buffer never goes back to reading
> state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
