[
https://issues.apache.org/jira/browse/THRIFT-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036176#comment-15036176
]
ASF GitHub Bot commented on THRIFT-3468:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/728
THRIFT-3468 Match type in TSocketTransport onError handler to stream type
Change the type of the onError handler to match the stream's type (which is
untyped Object).
Also ignore the test coverage output directory, for the dart lib.
https://issues.apache.org/jira/browse/THRIFT-3468
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift
untyped_error_in_socket_transport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #728
----
commit da8b5912a80204f60bbe665adbce3c2515dd511e
Author: Mark Erickson <mark.erick...@workiva.com>
Date: 2015-12-02T15:53:27Z
Change the type of the onError handler to match the stream's type (which is
untyped Object).
https://issues.apache.org/jira/browse/THRIFT-3468
----
> Dart TSocketTransport onError handler is too restrictive
> --------------------------------------------------------
>
> Key: THRIFT-3468
> URL: https://issues.apache.org/jira/browse/THRIFT-3468
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Library
> Reporter: Mark Erickson
> Assignee: Mark Erickson
>
> PROBLEM
> Dart TSocketTransport listens to the TSocket.onError stream. It was
> incorrectly expecting a String, when the stream's type is Object.
> SOLUTION
> Accept an Object, to match the stream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
