[
https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054961#comment-15054961
]
ASF GitHub Bot commented on THRIFT-3485:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/741#issuecomment-164258574
It seems it's already fixed by f264884901d0e2a1197ae1511ee0fa0b8ca0d2aa.
@azylman could you confirm ?
> thrift NPM package includes whole thrift repository, is 30 megabytes
> --------------------------------------------------------------------
>
> Key: THRIFT-3485
> URL: https://issues.apache.org/jira/browse/THRIFT-3485
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.3
> Reporter: Alex Zylman
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The thrift npm package is as big as all of our other node dependencies
> combined. It currently publishes the entire thrift repository, which is ~30mb
> right now. As far as I can tell, it only requires lib/nodejs, which is 376k.
> I propose adding an .npmignore file. You can more info in the npm
> documentation:
> https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
> If the package only requires lib/nodejs, we should be able to add an entry to
> the npmignore file for every folder (including lib), and then a negated entry
> for lib/nodejs. We'll also want to include everything from gitignore, because
> npm will no longer use that once an npmignore file is added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
