[
https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065767#comment-15065767
]
ASF GitHub Bot commented on THRIFT-2994:
----------------------------------------
Github user timse commented on a diff in the pull request:
https://github.com/apache/thrift/pull/379#discussion_r48103666
--- Diff: lib/nodejs/lib/thrift/json_protocol.js ---
@@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET;
TJSONProtocol.Version = 1;
TJSONProtocol.prototype.flush = function() {
+ this.writeToTransportIfStackIfFlushable();
--- End diff --
done :)
> Node.js TJSONProtocol cannot be used for object serialization.
> --------------------------------------------------------------
>
> Key: THRIFT-2994
> URL: https://issues.apache.org/jira/browse/THRIFT-2994
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Reporter: Jan Brauer
> Assignee: Randy Abernethy
>
> Consider the following code using the Thrift example types.
> {code:title=serialize.js|borderStyle=solid}
> var thrift = require('thrift');
> var test_types = require('gen-nodejs/ThriftTest_types.js');
> var bonk = new test_types.Bonk({message: "message", type: 6})
> var t_out = new thrift.TBufferedTransport();
> var p_out = new thrift.TJSONProtocol(t_out);
> bonk.write(p_out);
> var out
> t_out.flush(function (b) { out = b;});
> console.log(out)
> {code}
> My expectation would be for {{out}} to contain the serialized {{Bonk}} struct.
> But due to
> [TJSONProtocol|https://github.com/apache/thrift/blob/master/lib/nodejs/lib/thrift/protocol.js#L1287]
> only writing to the underlying transport in {{writeMessageEnd}} the above
> code does not work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
