[
https://issues.apache.org/jira/browse/THRIFT-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065914#comment-15065914
]
ASF GitHub Bot commented on THRIFT-3386:
----------------------------------------
GitHub user simonsouth opened a pull request:
https://github.com/apache/thrift/pull/751
THRIFT-3386 misc. warnings with make check
At long last, here's a patch that adds explicit casts to the C (GLib) test
code to prevent compiler warnings during `make check`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonsouth/thrift
thrift-3386-misc-warnings-with-make-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #751
----
commit b6e8f0d77ccf956cc7e6b651d1705b83b305354d
Author: Simon South <si...@simonsouth.com>
Date: 2015-12-20T22:44:24Z
THRIFT-3386 misc. warnings with make check
c_glib: Add explicit casts to prevent compiler warnings during "make
check"
----
> misc. warnings with make check
> ------------------------------
>
> Key: THRIFT-3386
> URL: https://issues.apache.org/jira/browse/THRIFT-3386
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Compiler, C glib - Library
> Reporter: Jens Geyer
> Assignee: Simon South
> Priority: Minor
>
> Aside from THRIFT-3385, I also get some pointer-related and const-related
> warnings in the same source code area, like:
> {code}
> /usr/include/glib-2.0/glib/ghash.h:67:13: note: expected ‘gpointer’ but
> argument is of type ‘const struct TTestInsanity *’
> gboolean g_hash_table_insert (GHashTable *hash_table,
> {code}
> and
> {code}
> src/thrift_test_handler.c:527:3: warning: passing argument 1 of
> ‘g_object_ref’ discards ‘const’ qualifier from pointer target type [enabled
> by default]
> g_object_ref (argument);
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
