[
https://issues.apache.org/jira/browse/THRIFT-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076477#comment-15076477
]
ASF GitHub Bot commented on THRIFT-3514:
----------------------------------------
GitHub user dsp opened a pull request:
https://github.com/apache/thrift/pull/765
THRIFT-3514: Add PHP 7 version of php_thrift_protocol
This is an initial port of php_thrift_protocol to PHP7 and an RFC how to
approach it.
However as we deal with zval's all over the place, we opt for separating
the C files completely leading to some overhead. However this
is a good start to see the differences in the implementation. From
there we should follow up with a more unified approach by refactoring
parts of the zval handling to be more generic so we can plug it
into PHP 7 and PHP 5 extensions.
Tested this by running with TestClient.php against a CPP server
and using TBinaryProtocolAccelerated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsp/thrift php7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #765
----
commit 51e10427629a5fe6bf28a3d44ffef4591b22a28b
Author: David Soria Parra <d...@php.net>
Date: 2015-12-28T18:05:12Z
THRIFT-3514: Add PHP 7 version of php_thrift_protocol
This is an initial port of php_thrift_protocol to PHP7. However as
we deal with zval's all over the place, we opt for separating
the C files completely leading to some overhead. However this
is a good start to see the differences in the implementation. From
there we should follow up with a more unified approach by refactoring
parts of the zval handling to be more generic so we can plug it
into PHP 7 and PHP 5 extensions.
Tested this by running with TestClient.php against a CPP server
and using TBinaryProtocolAccelerated.
----
> PHP 7 compatible version of binary protocol
> -------------------------------------------
>
> Key: THRIFT-3514
> URL: https://issues.apache.org/jira/browse/THRIFT-3514
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Reporter: David Soria Parra
> Fix For: 1.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
