[
https://issues.apache.org/jira/browse/THRIFT-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090446#comment-15090446
]
Kapil Joshi edited comment on THRIFT-3314 at 1/9/16 6:24 AM:
-------------------------------------------------------------
[~jensg]
This is my first open source contribution as well as first coding in C++.
So have gone through a lot of examples. You know what I am referring to ;) :).
BTW thanks for the commit.
was (Author: joshkaps):
[~jensg]
This is my first open source contribution as well as first coding in C++.
So have gone through a lot of examples. You know what I am referring to ;) :).
> Dots in file names of includes causes dots in javascript variable names
> -----------------------------------------------------------------------
>
> Key: THRIFT-3314
> URL: https://issues.apache.org/jira/browse/THRIFT-3314
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Reporter: Matt Fysh
> Assignee: Kapil Joshi
> Fix For: 1.0
>
> Attachments: thrift-3314-feature.patch
>
>
> Hi there,
> {code:title=a.thrift}
> include "b.c.thrift"
> {code}
> {code:title=b.c.thrift}
> # nada
> {code}
> {{$ thrift -r --gen js:node a.thrift}}
> {code:title=gen-nodejs/a_types}
> //
> // Autogenerated by Thrift Compiler (0.9.2)
> //
> // DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
> //
> var thrift = require('thrift');
> var Thrift = thrift.Thrift;
> var Q = thrift.Q;
> var b.c_ttypes = require('./b.c_types')
> var ttypes = module.exports = {};
> {code}
> One variable in the auto-generated thrift output contains a dot, which is not
> valid JavaScript and will not compile.
> Cheers,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
