[ https://issues.apache.org/jira/browse/THRIFT-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104939#comment-15104939 ]
ASF GitHub Bot commented on THRIFT-3565: ---------------------------------------- GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/803 THRIFT-3565: C++: declared T{Async}Processor::getEventHandler() as const member functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker/thrift THRIFT-3565 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/803.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #803 ---- commit c1d9ab0caf6022b31da344fe423626fd3867d131 Author: Sebastian Zenker <sebastian.zen...@gmx.de> Date: 2016-01-18T07:51:30Z C++: declared T{Async}Processor::getEventHandler() as const member function ---- > C++: T[Async]Processor::getEventHandler() should be declared as const member > functions > -------------------------------------------------------------------------------------- > > Key: THRIFT-3565 > URL: https://issues.apache.org/jira/browse/THRIFT-3565 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9.3, 0.9.4, 1.0 > Reporter: Sebastian Zenker > Priority: Minor > Labels: easyfix > > getEventHandler() shouldn't alter the state of TProcessor and > TAsyncProcessor. Therefor they should be declared as const member functions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)