GitHub user szenker opened a pull request:
https://github.com/apache/thrift/pull/804
THRIFT-3566: fixed TQTcpServerTest - it was never executed and working
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/szenker/thrift THRIFT-3566
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/804.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #804
----
commit c6e18e506d24123e323b2a190d8ddddc01ae572c
Author: Sebastian Zenker <sebastian.zen...@gmx.de>
Date: 2016-01-18T07:37:54Z
C++/Qt: TQTcpServerTest did never execute the actual test method
test_communicate() as it wasn't declared as a Qt slot. The test gets now
executed but it is broken because server and (synchronous) client cannot be
executed in the same thread.
commit 9bfd6f322a9b87e93490c669fda448f8097fed3b
Author: Sebastian Zenker <sebastian.zen...@gmx.de>
Date: 2016-01-18T07:38:23Z
C++/Qt: TQTcpServerTest: converted class members into local variables which
don't need to be part of the test class
commit 0e0708571d312b7f5fe826fa2bb919f2246fe88e
Author: Sebastian Zenker <sebastian.zen...@gmx.de>
Date: 2016-01-18T07:39:07Z
C++/Qt: fixed TQTcpServerTest by moving the server into it's own thread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
