[
https://issues.apache.org/jira/browse/THRIFT-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105465#comment-15105465
]
ASF GitHub Bot commented on THRIFT-3545:
----------------------------------------
Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172571012
Ah, my apologies for the extra semicolons. It was missing semicolons in the
default init methods where a collection type had a default value.
I believe this semicolon problem is due to discrepancies in how the caller
of this method assumes code will be generated--with semicolons and line breaks
or not. I think if the call sites were to be cleaned up the ugliness would go
away. I believe I checked them but I might've overlooked them. I'll give it
another look again later too.
The NSSet change should've been in another PR, I admit, but it was for
performance reasons (since one of Thrift's main goals is performance). I
believe that optimized ARC code cannot cancel out the autorelease that
setWithArray makes because Foundation isn't using ARC itself (I think, but it's
worth testing.) Even if it could I think it's still faster to not have to have
it back out of autoreleasing. I considered changing it to the initWithObjects
variant but it seemed a little too drastic and needs performance testing.
> Container type literals do not compile
> --------------------------------------
>
> Key: THRIFT-3545
> URL: https://issues.apache.org/jira/browse/THRIFT-3545
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Compiler
> Affects Versions: 1.0
> Reporter: Christopher Rogers
> Assignee: Christopher Rogers
> Fix For: 1.0
>
>
> Default values and constants of container type (array, dictionary, and set)
> do not compile. Semicolons are missing, and sets are missing an opening
> square bracket.
> I will provide a patch/pull request for this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
