[ https://issues.apache.org/jira/browse/THRIFT-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113831#comment-15113831 ]
ASF GitHub Bot commented on THRIFT-3578: ---------------------------------------- Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/817#discussion_r50622119 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h --- @@ -39,9 +39,11 @@ enum CLIENT_TYPE { THRIFT_HEADER_CLIENT_TYPE = 0, - THRIFT_FRAMED_DEPRECATED = 1, - THRIFT_UNFRAMED_DEPRECATED = 2, - THRIFT_UNKNOWN_CLIENT_TYPE = 4, + THRIFT_FRAMED_BINARY = 1, --- End diff -- @andrewcox @djwatson Here I presume `_DEPRECATED` is only true for fbthrift. Or is there any reason we should keep them and add the suffix to `COMPACT` ? > Make THeaderTransport detect TCompact framed and unframed > --------------------------------------------------------- > > Key: THRIFT-3578 > URL: https://issues.apache.org/jira/browse/THRIFT-3578 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Reporter: Aki Sukegawa > Assignee: Aki Sukegawa > Priority: Minor > > THeaderTransport detect TBinaryProtocol with either framed or unframed > protocol and acts as if it's plain TBinaryProtocol. > Adding new protocol support is safe as long as its protocol ID is large > enough so that size can never have the same value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)