Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/822#discussion_r50898264
--- Diff: lib/java/src/org/apache/thrift/TApplicationException.java ---
@@ -73,7 +74,18 @@ public int getType() {
return type_;
}
- public static TApplicationException read(TProtocol iprot) throws
TException {
--- End diff --
Technically this is a breaking change. However this is not a method that
would typically be used by applications I think, so the impact would probably
be very low... and even for affected applications, it should be easy to fix
(that is, create a new `TApplicationException` and call the read method). It
might be nice to add a static convenience method as a replacement (named
`TApplicationException.readFrom(protocol)` or something like that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
