[
https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117988#comment-15117988
]
ASF GitHub Bot commented on THRIFT-2157:
----------------------------------------
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/822#discussion_r50898264
--- Diff: lib/java/src/org/apache/thrift/TApplicationException.java ---
@@ -73,7 +74,18 @@ public int getType() {
return type_;
}
- public static TApplicationException read(TProtocol iprot) throws
TException {
--- End diff --
Technically this is a breaking change. However this is not a method that
would typically be used by applications I think, so the impact would probably
be very low... and even for affected applications, it should be easy to fix
(that is, create a new `TApplicationException` and call the read method). It
might be nice to add a static convenience method as a replacement (named
`TApplicationException.readFrom(protocol)` or something like that)
> generated code would cause ClassCastException
> ---------------------------------------------
>
> Key: THRIFT-2157
> URL: https://issues.apache.org/jira/browse/THRIFT-2157
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.9.1
> Reporter: Dave Brosius
> Priority: Trivial
>
> Looking at the thrift generated code for cassandra, i'm seeing
> msg = (org.apache.thrift.TBase)new
> org.apache.thrift.TApplicationException(org.apache.thrift.TApplicationException.INTERNAL_ERROR,
> e.getMessage());
> as seen here
> https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blob;f=interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java;h=837acfc0e964249fd62720420e8f1f85d966f1a3;hb=8f202895ab9e17c3d6bd4965924fd5f1ffc27f94#l6095
> i don't see how TApplicationException can be cast to TBase, and so i'd expect
> a ClassCastException there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
