Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/828#issuecomment-178683522
Tested with `test/lua/test_basic_client.lua` and found several problems.
Examples of problematic valus were negative i8 values (-128 ~ -1), some i32
values (0x40000000, -1 ...), i64 values.
For i64 values, we need it to work with `liblualongnumber.new`.
I recommend you to run the test yourself. Here's how:
1. pull master branch
2. `make precross`
3. in `test/go/bin` run `./testserver --protocol=compact
--transport=framed` (leave it blocked)
4. uncommend compact entry around line 75 in
`test/lua/test_basic_client.lua`. also add require to compact
5. in `test/lua` run `lua test_basic_client.lua --transport=framed
--protocol=compact` with appropriate LUA_PATH and LUA_CPATH
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
