[ https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128557#comment-15128557 ]
ASF GitHub Bot commented on THRIFT-3596: ---------------------------------------- GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/832 THRIFT-3596 Better conformance to PEP8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3596 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #832 ---- commit 2cd41d05d6186c61fe4a5f2177e8f4b12261af9b Author: Nobuaki Sukegawa <ns...@apache.org> Date: 2016-02-02T16:57:03Z THRIFT-3596 Better conformance to PEP8 autopep8 --ignore=E501,E301,E309 commit 2d28ed127856ebd1d8401520cb9393e74ff63771 Author: Nobuaki Sukegawa <ns...@apache.org> Date: 2016-02-02T16:58:52Z THRIFT-3596 Better conformance to PEP8 Manual fixes ---- > Better conformance to PEP8 > -------------------------- > > Key: THRIFT-3596 > URL: https://issues.apache.org/jira/browse/THRIFT-3596 > Project: Thrift > Issue Type: Improvement > Components: Python - Library > Reporter: Aki Sukegawa > Priority: Minor > Labels: RFC > > py coding_standards.md states it follows PEP8 but currently it does not do so > at all. > So a typical experience of a first-time (potential) py contributor's > experience would be to see red warnings all over the display and then has to > either adjust their editor's settings or stop there. > On the other hand, a huge downside of global reformat is git-blame experience > but will be mostly mitigated by git blame -w in this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)