Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/833#issuecomment-179569186
Looks like python tests are broken or flaky:
https://travis-ci.org/apache/thrift/jobs/106875786
```
.
----------------------------------------------------------------------
Ran 1 test in 0.000s
OK
/usr/bin/python3 test/test_sslsocket.py
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:227:
DeprecationWarning: Use cert_reqs instead
warnings.warn('Use cert_reqs instead', DeprecationWarning)
test/test_sslsocket.py:193: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41458, 0, 0)>
self._assert_connection_success(server, client)
Error while connecting with ('::1', 23458, 0, 0). Trying next one.
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake
failure (_ssl.c:600)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:242:
ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET6,
type=2049, proto=0, laddr=('::1', 41459, 0, 0), raddr=('::1', 23458, 0, 0)>
self.handle = self._wrap_socket(plain_sock)
Error while accepting from ('::1', 41459, 0, 0)
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
363, in accept
client = self._wrap_socket(plain_client)
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
155, in _wrap_socket
server_hostname=self._server_hostname)
File "/usr/lib/python3.4/ssl.py", line 365, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 601, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:600)
Error while connecting with ('127.0.0.1', 23458).
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:584: The handshake operation timed out
Error while connecting with ('::1', 23458, 0, 0). Trying next one.
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake
failure (_ssl.c:600)
Error while accepting from ('::1', 41461, 0, 0)
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
363, in accept
client = self._wrap_socket(plain_client)
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
155, in _wrap_socket
server_hostname=self._server_hostname)
File "/usr/lib/python3.4/ssl.py", line 365, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 601, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:600)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:242:
ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET6,
type=2049, proto=0, laddr=('::1', 41461, 0, 0), raddr=('::1', 23458, 0, 0)>
self.handle = self._wrap_socket(plain_sock)
Error while connecting with ('127.0.0.1', 23458).
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:584: The handshake operation timed out
.test/test_sslsocket.py:188: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41463, 0, 0)>
self._assert_connection_success(server, client)
./thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:227:
DeprecationWarning: Use cert_reqs instead
warnings.warn('Use cert_reqs instead', DeprecationWarning)
test/test_sslsocket.py:130: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41464, 0, 0)>
self._assert_connection_success(server, client)
.test/test_sslsocket.py:240: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41465, 0, 0)>
self._assert_connection_success(server, client)
Fsys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41466, 0, 0)>
test/test_sslsocket.py:162: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41467, 0, 0)>
self._assert_connection_success(server, client)
Error while accepting from ('::1', 41468, 0, 0)
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
363, in accept
client = self._wrap_socket(plain_client)
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
155, in _wrap_socket
server_hostname=self._server_hostname)
File "/usr/lib/python3.4/ssl.py", line 365, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 601, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca
(_ssl.c:600)
Error while connecting with ('::1', 23458, 0, 0). Trying next one.
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed
(_ssl.c:600)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:242:
ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET6,
type=2049, proto=0, laddr=('::1', 41468, 0, 0), raddr=('::1', 23458, 0, 0)>
self.handle = self._wrap_socket(plain_sock)
Error while connecting with ('127.0.0.1', 23458).
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:584: The handshake operation timed out
test/test_sslsocket.py:171: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41470, 0, 0)>
self._assert_connection_success(server, client)
./thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:216:
DeprecationWarning: validate is deprecated. Use cert_reqs=ssl.CERT_REQUIRED
instead
DeprecationWarning)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:216:
DeprecationWarning: validate is deprecated. Use cert_reqs=ssl.CERT_NONE instead
DeprecationWarning)
.test/test_sslsocket.py:181: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41471, 0, 0)>
self._assert_connection_success(server, client)
..Error while accepting from ('::1', 41472, 0, 0)
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
363, in accept
client = self._wrap_socket(plain_client)
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
155, in _wrap_socket
server_hostname=self._server_hostname)
File "/usr/lib/python3.4/ssl.py", line 365, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 601, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:600)
Error while connecting with ('::1', 23458, 0, 0). Trying next one.
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake
failure (_ssl.c:600)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:242:
ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET6,
type=2049, proto=0, laddr=('::1', 41472, 0, 0), raddr=('::1', 23458, 0, 0)>
self.handle = self._wrap_socket(plain_sock)
Error while connecting with ('127.0.0.1', 23458).
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:584: The handshake operation timed out
Error while connecting with ('::1', 23458, 0, 0). Trying next one.
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: UNSUPPORTED_PROTOCOL] unsupported protocol (_ssl.c:600)
/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py:242:
ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET6,
type=2049, proto=0, laddr=('::1', 41474, 0, 0), raddr=('::1', 23458, 0, 0)>
self.handle = self._wrap_socket(plain_sock)
Exception in thread Thread-13:
Traceback (most recent call last):
File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
self.run()
File "test/test_sslsocket.py", line 56, in run
self.client = self._server.accept()
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
363, in accept
client = self._wrap_socket(plain_client)
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
155, in _wrap_socket
server_hostname=self._server_hostname)
File "/usr/lib/python3.4/ssl.py", line 365, in wrap_socket
_context=self)
File "/usr/lib/python3.4/ssl.py", line 601, in __init__
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
ConnectionResetError: [Errno 104] Connection reset by peer
Error while connecting with ('127.0.0.1', 23458).
Traceback (most recent call last):
File "/thrift/src/lib/py/build/lib/thrift/transport/TSSLSocket.py", line
245, in open
self.handle.connect(ip_port)
File "/usr/lib/python3.4/ssl.py", line 864, in connect
self._real_connect(addr, False)
File "/usr/lib/python3.4/ssl.py", line 855, in _real_connect
self.do_handshake()
File "/usr/lib/python3.4/ssl.py", line 828, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:584: The handshake operation timed out
PROTOCOL_SSLv2 is not available
.test/test_sslsocket.py:271: ResourceWarning: unclosed <ssl.SSLSocket fd=4,
family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
laddr=('::1', 23458, 0, 0), raddr=('::1', 41476, 0, 0)>
self._assert_connection_success(server, client)
.test/test_sslsocket.py:55: ResourceWarning: unclosed <socket.socket fd=3,
family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0>
self._server.listen()
test/test_sslsocket.py:157: ResourceWarning: unclosed <ssl.SSLSocket fd=3,
family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0,
laddr=/tmp/.thrift.domain.sock.23458>
self._assert_connection_success(server, client)
.
======================================================================
FAIL: test_newer_tls (__main__.TSSLSocketTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test/test_sslsocket.py", line 247, in test_newer_tls
self._assert_connection_success(server, client)
File "test/test_sslsocket.py", line 104, in _assert_connection_success
self.assertTrue(acc.client is not None)
AssertionError: False is not true
----------------------------------------------------------------------
Ran 11 tests in 4.140s
FAILED (failures=1)
make[3]: *** [py3-test] Error 1
make[3]: Leaving directory `/thrift/src/lib/py'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/thrift/src/lib/py'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/thrift/src/lib'
make: *** [check-recursive] Error 1
```
I'll investigate this locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
