[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134042#comment-15134042 ]
Hudson commented on THRIFT-3595: -------------------------------- FAILURE: Integrated in Thrift-precommit #40 (See [https://builds.apache.org/job/Thrift-precommit/40/]) THRIFT-3595 Perl: Unify implementation of set as a hashref (adam: [https://github.com/apache/thrift/commit/5f0f0cf57ad8c38b0b2206813a600d700aa181ac]) * test/perl/TestServer.pl * test/perl/TestClient.pl * compiler/cpp/src/generate/t_perl_generator.cc THRIFT-3595: Implement constant set as a hashref (adam: [https://github.com/apache/thrift/commit/eb067fe5b512693cde481dd288556c01a7c666d7]) * test/perl/TestServer.pl * compiler/cpp/src/generate/t_perl_generator.cc > Perl Bindings: Set serialization/deserialization differs > -------------------------------------------------------- > > Key: THRIFT-3595 > URL: https://issues.apache.org/jira/browse/THRIFT-3595 > Project: Thrift > Issue Type: Bug > Components: Perl - Compiler > Affects Versions: 0.9.1, 0.9.2, 0.9.3 > Reporter: Adam Millerchip > > In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the > serialization code expects an arrayref. This causes the code to die when > called if attempting to serialize a previously dezerialized Set. > Additionally, it looks like there is a typo in the test that is testing this > feature: > https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262 > If you change that {{@$setout}} to {{@$setin}}, the test fails. > It doesn't make much sense to implement a Set in Perl as array, because > arrays allow duplicate entries and are ordered. > I've written a change for the serialization that correctly expects a hashref: > https://github.com/apache/thrift/pull/831 -- This message was sent by Atlassian JIRA (v6.3.4#6332)