[
https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145633#comment-15145633
]
ASF GitHub Bot commented on THRIFT-3621:
----------------------------------------
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/854
THRIFT-3621 Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephem…
…eral ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TSSLServerSocket` listening on an ephemeral port would be
DRYed up into a helper of some sort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3623
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #854
----
commit fbdbceb9b4c912b87d4ddd93ac397b41ef6b5f25
Author: John Sirois <jsir...@apache.org>
Date: 2016-02-13T00:44:01Z
THRIFT-3621 Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral
ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TSSLServerSocket` listening on an ephemeral port would be
DRYed up into a helper of some sort.
----
> Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports
> --------------------------------------------------------
>
> Key: THRIFT-3621
> URL: https://issues.apache.org/jira/browse/THRIFT-3621
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library, Test Suite
> Reporter: John Sirois
> Assignee: John Sirois
>
> As part of work on THRIFT-3609, eliminate use of TestPortFixture.h from
> SecurityTest,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
