[
https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145948#comment-15145948
]
Hudson commented on THRIFT-3627:
--------------------------------
SUCCESS: Integrated in Thrift-precommit #118 (See
[https://builds.apache.org/job/Thrift-precommit/118/])
THRIFT-3627 fix missing basic code style consistency of JavaScript.
(kazuki.matsuda:
[https://github.com/apache/thrift/commit/10098945c31fa0ef07b82af6afd1fdd00241c932])
* lib/js/test/test.js
* lib/js/test/test_handler.js
* lib/js/test/server_http.js
* lib/js/test/server_https.js
* lib/js/test/test-jq.js
* lib/js/test/test-nojq.js
* lib/js/test/phantomjs-qunit.js
* lib/js/test/test-async.js
* lib/js/test/deep-constructor.test.js
* lib/js/src/thrift.js
* lib/js/test/phantom-client.js
> Missing basic code style consistency of JavaScript.
> ---------------------------------------------------
>
> Key: THRIFT-3627
> URL: https://issues.apache.org/jira/browse/THRIFT-3627
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library
> Reporter: Kazuki Matsuda
> Priority: Minor
>
> E.g.)
> * No white space in {code}function(args){// beteween `){`{code}
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497
> * "Double quoted" (not 'single quoted') string litteral
> https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133
> Those errors can be easily fixed by fixjsstyle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
