[ 
https://issues.apache.org/jira/browse/THRIFT-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146331#comment-15146331
 ] 

Hudson commented on THRIFT-3605:
--------------------------------

SUCCESS: Integrated in Thrift-precommit #134 (See 
[https://builds.apache.org/job/Thrift-precommit/134/])
THRIFT-3605 Have the compiler complain about invalid arguments and (jensg: 
[https://github.com/apache/thrift/commit/aaaa90803a353677aa605497ebe1970c7e92239d])
* compiler/cpp/src/generate/t_perl_generator.cc
* compiler/cpp/src/generate/t_hs_generator.cc
* compiler/cpp/src/generate/t_rb_generator.cc
* compiler/cpp/src/generate/t_java_generator.cc
* 
contrib/thrift-maven-plugin/src/test/java/org/apache/thrift/maven/TestThrift.java
* compiler/cpp/src/generate/t_cocoa_generator.cc
* 
contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java
* compiler/cpp/src/generate/t_html_generator.cc
* compiler/cpp/src/generate/t_xsd_generator.cc
* compiler/cpp/src/generate/t_php_generator.cc
* compiler/cpp/src/generate/t_st_generator.cc
* compiler/cpp/src/generate/t_c_glib_generator.cc
* compiler/cpp/src/generate/t_erl_generator.cc
* compiler/cpp/src/generate/t_cpp_generator.cc
* compiler/cpp/src/generate/t_json_generator.cc
* compiler/cpp/src/generate/t_dart_generator.cc
* compiler/cpp/src/generate/t_ocaml_generator.cc
* compiler/cpp/src/generate/t_xml_generator.cc
* compiler/cpp/src/generate/t_delphi_generator.cc
* compiler/cpp/src/generate/t_javame_generator.cc
* compiler/cpp/src/generate/t_d_generator.cc
* compiler/cpp/src/generate/t_gv_generator.cc
* compiler/cpp/src/generate/t_haxe_generator.cc
* compiler/cpp/src/generate/t_py_generator.cc
* compiler/cpp/src/generate/t_lua_generator.cc
* compiler/cpp/src/generate/t_js_generator.cc
* compiler/cpp/src/generate/t_go_generator.cc
* compiler/cpp/src/generate/t_csharp_generator.cc
* compiler/cpp/src/generate/t_as3_generator.cc
* lib/java/build.xml
* compiler/cpp/src/generate/t_swift_generator.cc


> Have the compiler complain about invalid arguments and options
> --------------------------------------------------------------
>
>                 Key: THRIFT-3605
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3605
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>
> As kind of a follow-up to THRIFT-3603, the goal is to have the compiler 
> validate not only the arguments , but also any argument options passed to it. 
> If an unknown option is found, a short error message should be printed 
> similar to what we already have with invalid args:
> {code}
> $ thrift -gen csharp:whoa
> Unrecognized option: whoa
> Usage: thrift [options] file
> Use thrift -help for a list of options
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to