[ 
https://issues.apache.org/jira/browse/THRIFT-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146846#comment-15146846
 ] 

WangYaofu commented on THRIFT-3631:
-----------------------------------

The precision is 15 bits after dot of format casting from double to string in 
Thrift-cpp-library- json-protocol.
But the precision is 16 bits after dot in Thrift-lua-library-json-protocol.
So, test with C++ server is break.
@nsuke can we modify the precision to 16 bits for C++ server?

The solution:
To Change code 'str.precision(std::numeric_limits<double>::digits10 + 1);' to 
'str.precision(std::numeric_limits<double>::digits10 + 2);'
in function doubeToString  file TJSONProtocol.cpp at line 524,

e.g:
before:
In C++ TJsonProtocol.cpp:
double a = 1.12345678906666663;
string astr = doubleToString(a);
double b = stringToDouble(astr);

the result as below:
a      = 1.1234567890666667
astr = "1.123456789066667"
b =      1.1234567890666669

after changing:
the result as below:
a      = 1.1234567890666667
astr = "1.1234567890666667"
b =      1.1234567890666667
This result is expected.


> JSON protocol implementation for Lua
> ------------------------------------
>
>                 Key: THRIFT-3631
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3631
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Lua - Library
>    Affects Versions: 0.9.3
>         Environment: Linux Mac Windows
>            Reporter: WangYaofu
>            Assignee: WangYaofu
>             Fix For: 0.9.4
>
>
> This is JSON protocol implement for thrift-lua library.
> TJsonProtocol.lua is new source of lua for thrift JSON protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to