[
https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147394#comment-15147394
]
Jake Farrell commented on THRIFT-3620:
--------------------------------------
the build should be in a docker container, not privileged. My thought was to
have the jenkins script be something that setup our base docker container and
then ran the jenkins build script. jenkins command would be something like
{code}
docker build -t thrift-precommit $WORKSPACE/build/docker/ubuntu
docker run --it --rm --entry-point /thrift/build/jenkins/run_tests.sh
thrift-precommit
{code}
> Cleanup and consolidate Thrift* jenkins jobs.
> ---------------------------------------------
>
> Key: THRIFT-3620
> URL: https://issues.apache.org/jira/browse/THRIFT-3620
> Project: Thrift
> Issue Type: Task
> Components: Test Suite
> Reporter: John Sirois
> Assignee: John Sirois
>
> I spent some time resurrecting the
> [Thrift-precommit|https://builds.apache.org/job/Thrift-precommit/] job which
> vets pull-requests to use the pool of docker slaves using a dockerized CI
> with guidance from [~jfarrell]. The remaining crop of Thrift* jobs should be
> culled and converted as appropriate.
> Currently we have the jobs
> [here|https://builds.apache.org/view/S-Z/view/Thrift/]:
> {noformat}
> $ curl --netrc -sS https://builds.apache.org/view/S-Z/view/Thrift/config.xml
> | xmllint -xpath "//jobNames" - | grep "<string>" | cut -d'>' -f2 | cut -d'<'
> -f1
> Thrift
> Thrift-all
> Thrift-Compiler-Linux64
> Thrift-Compiler-Windows
> Thrift-env
> Thrift-env-Windows
> Thrift-Test
> Thrift-Windows
> {noformat}
> Of those, [Thrift-env|https://builds.apache.org/job/Thrift-env],
> [Thrift-env-Windows|https://builds.apache.org/job/Thrift-env-Windows] and
> [Thrift-Windows|https://builds.apache.org/job/Thrift-Windows] are all
> disabled and [Thrift|https://builds.apache.org/job/Thrift] and
> [Thrift-Compiler-Linux64|https://builds.apache.org/job/Thrift-Compiler-Linux64]
> seem to be unused based on last run dates. This leaves the following active
> jobs fwict:
> * [|https://builds.apache.org/job/Thrift-all]
> * [|https://builds.apache.org/job/Thrift-Compiler-Windows]
> * [|https://builds.apache.org/job/Thrift-precommit]
> Of these {{Thrift-all}} is broken in a known-way, it really needs to be
> converted to use a Dockerized build like {{Thrift-precommit}} to be insulated
> from the vagaries of the underlying worker machines.
> I propose deltion of all disabled (3) and inactive (2) jobs listed above and
> conversion of {{Thrift-all}} to a Dockerized CI job to guard master with.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
