Hi, > attach jira to the precommit jenkins builds also
That is possible? Pulling the patch file and do a build? I was not aware of that. JensG ________________________________ Von: Jake Farrell Gesendet: 16.02.2016 04:37 An: dev@thrift.apache.org Betreff: Re: [DISCUSSION] Patches and precommits We can attach jira to the precommit jenkins builds also, but would not be opposed to moving to all patches landing on github as long as the requirement of a jira being associated with each issue is maintained -Jake On Mon, Feb 15, 2016 at 4:53 PM, Jens Geyer <jensge...@hotmail.com> wrote: > Hi *, > > now that we have working precommit checks up and running (thanks for all > the work, guys – that’s just great!), I wonder if we should still accept > patch files, for a simple reason: Patch files added to JIRA attachments > obviously do not participate in the precommits. That’s unfortunate, and > hence does not contribute anymore to the high quality level we want. > > Is there a chance we can switch over to pull requests entirely? Or maybe > we make it mandatory for changes of a certain size? But where to draw the > line? Even one minorish typo at the right place can make the difference > between make and break. > > What do you think? > JensG
