[
https://issues.apache.org/jira/browse/THRIFT-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152499#comment-15152499
]
ASF GitHub Bot commented on THRIFT-3647:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/878
THRIFT-3647 Fix php extension build warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3647
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/878.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #878
----
commit 48ff2b24450ca84a3e1e766991d897edac19603a
Author: Nobuaki Sukegawa <[email protected]>
Date: 2016-02-18T16:03:24Z
THRIFT-3647 Fix php extension build warnings
----
> Fix php extension build warnings
> --------------------------------
>
> Key: THRIFT-3647
> URL: https://issues.apache.org/jira/browse/THRIFT-3647
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Trivial
>
> It's caused by passing string literals as non-const char* method arguments.
> It turned out that those parameters didn't need to be non-const.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
