[
https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156088#comment-15156088
]
ASF GitHub Bot commented on THRIFT-3657:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/884
THRIFT-3657 D TFileWriterTransport close should use non-priority send
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3657
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/884.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #884
----
commit 9f96e358fb5bdac8a6570dc3c79e9416e4f407ce
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-21T16:33:27Z
THRIFT-3577 assertion failed at line 512 of testcontainertest.c
commit cad72823e3b07124d50f10bc350cd8c3cbc9ca3e
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-21T16:43:23Z
THRIFT-3635 D transport_test is flaky on Jenkins and Travis
commit 2c3edc08c292c5bb35d3a454742163b88129f9b5
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-21T17:16:30Z
THRIFT-3657 D TFileWriterTransport close should use non-priority send
----
> D TFileWriterTransport close should use non-priority send
> ---------------------------------------------------------
>
> Key: THRIFT-3657
> URL: https://issues.apache.org/jira/browse/THRIFT-3657
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Trivial
>
> prioritySend is used in TFileWriterTransport close method.
> A possible problem with this is that even synchronized calls that are
> strictly before close call can be ignored in rare occasions.
> The author has put a comment "FIXME: Should use normal send here" and there's
> no reason not to.
> I suspect it is a remnant of old implementation or local debug stuff.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
