[ https://issues.apache.org/jira/browse/THRIFT-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170407#comment-15170407 ]
ASF GitHub Bot commented on THRIFT-3680: ---------------------------------------- GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/903 THRIFT-3680 Java async processor fails to notify errors to clients You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3680 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/903.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #903 ---- commit 3e08eb8119e8776683033a0c7b3d7e1f35c4800c Author: John Sirois <jsir...@apache.org> Date: 2016-02-08T20:04:36Z Fully parameterize java async client code. The parametrization brings the existing actual parametrization with client call implementation objects to the fore and so this change also fixes that parametrization to be a simple parametrization over the return type as is done in the server-side AsyncProcessor code. NB: This is a breaking change in both generated code and the client libs. commit a97c5fbe1525e4af5610d82087b719466e75df04 Author: Nobuaki Sukegawa <ns...@apache.org> Date: 2016-02-27T07:03:21Z Follow-up THRIFT-3112: key.cancel when error commit 2c5df874e8459b445b7e689a35e98e83709780d8 Author: Nobuaki Sukegawa <ns...@apache.org> Date: 2016-02-27T07:04:30Z THRIFT-3680 Java async processor fails to notify errors to clients ---- > Java async processor fails to notify errors to clients > ------------------------------------------------------ > > Key: THRIFT-3680 > URL: https://issues.apache.org/jira/browse/THRIFT-3680 > Project: Thrift > Issue Type: Bug > Components: Java - Library > Reporter: Aki Sukegawa > Assignee: Aki Sukegawa > > Unlike its sync counter part, Java async processor has been ignoring any > errors. > It turned out that it was actually trying to send errors back and failing to > do so because of other bugs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)