[
https://issues.apache.org/jira/browse/THRIFT-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172160#comment-15172160
]
ASF GitHub Bot commented on THRIFT-3699:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/915
THRIFT-3699 Fix integer limit symbol includes in Python C extension
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3699
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #915
----
commit d7ff35a3f03485d8652acc0406f9346bef89851f
Author: Nobuaki Sukegawa <[email protected]>
Date: 2016-02-29T16:41:47Z
THRIFT-3699 Fix integer limit symbol includes in Python C extension
----
> Fix integer limit symbol includes in Python C extension
> -------------------------------------------------------
>
> Key: THRIFT-3699
> URL: https://issues.apache.org/jira/browse/THRIFT-3699
> Project: Thrift
> Issue Type: Sub-task
> Components: Python - Library
> Affects Versions: 0.10.0
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> INT32_MAX etc was not included correctly
> Newer GCC and Clang are permissive enough to accept them but it didn't work
> on our CentOS 6 image.
> Rather than doing C-compatibility includes correctly, I replaced them with
> std::numeric_limits.
> The patch also adds workaround for VC++ where std::numeric_limits does not
> work in a single particular place of code for some reason.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
