[
https://issues.apache.org/jira/browse/THRIFT-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172904#comment-15172904
]
Hudson commented on THRIFT-3697:
--------------------------------
SUCCESS: Integrated in Thrift-precommit #241 (See
[https://builds.apache.org/job/Thrift-precommit/241/])
THRIFT-3697 Dart generator does not name imports Client: Dart Patch:
(merickson:
[https://github.com/apache/thrift/commit/b52d03d7a0c1ff2c1fe31c3999127d2daf98bc93])
* compiler/cpp/src/generate/t_dart_generator.cc
> Dart generator does not name imports
> ------------------------------------
>
> Key: THRIFT-3697
> URL: https://issues.apache.org/jira/browse/THRIFT-3697
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Compiler
> Reporter: Mark Erickson
> Assignee: Mark Erickson
> Fix For: 0.10.0
>
> Attachments:
> 0001-Name-imports-from-dependencies-to-avoid-naming-colli.patch
>
>
> h4. PROBLEM
> The example below results in a Dart analyzer error since the reference to
> b.Foo is ambiguous in the generated code.
> h4. FIX
> Name imports for dependencies to make references explicit.
> h4. EXAMPLE
> {code}thrift -r --gen dart a.thrift{code}
> a.thrift
> {code}
> include "b.thrift"
> namespace dart a
> /**@ Foo in a*/
> struct Foo {
> 1:string name
> }
> /**@ Bar in a*/
> struct Bar {
> 1:Foo aFoo,
> 2:b.Foo bFoo
> }
> {code}
> b.thrift
> {code}
> namespace dart b
> /**@ Foo in b*/
> struct Foo {
> 1:string name
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
