GitHub user markerickson-wf opened a pull request:

    https://github.com/apache/thrift/pull/917

    THRIFT-3702 Fix cross tests for Dart compact protocol (3 failing)

    I looked at Go-Dart locally, and the response body from the Go server 
appears to be empty.  Go server - Java client also fails for me for http.  So 
without much more time to investigate, I think the best course of action is to 
add these to known_failures_Linux.json to allow CI to pass.  There are already 
other combinations excluded for those server - transport pairs.
    
    go-dart                 compact      http-ip                  failure(13)
    hs-dart                 compact      framed-ip                failure(13)
    cpp-dart                compact      http-ip                  failure(13)
    
    THRIFT-3702
    
    @brianshannan-wf
    @stevenosborne-wf
    @tylertreat-wf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markerickson-wf/thrift thrift-3702

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #917
    
----
commit 57eede97d8b6a98f6e1d5479803bdebfeb0391b0
Author: Mark Erickson <mark.erick...@workiva.com>
Date:   2016-03-01T21:14:40Z

    I looked at Go-Dart locally, and the response body from the Go server 
appears to be empty.  Go server - Java client also fails for me for http.  So 
without much more time to investigate, I think the best course of action is to 
add these to known_failures_Linux.json to allow CI to pass.  There are already 
other combinations excluded for those server - transport pairs.
    
    go-dart                 compact      http-ip                  failure(13)
    hs-dart                 compact      framed-ip                failure(13)
    cpp-dart                compact      http-ip                  failure(13)
    
    THRIFT-3702

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to