[ https://issues.apache.org/jira/browse/THRIFT-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181897#comment-15181897 ]
ASF GitHub Bot commented on THRIFT-3714: ---------------------------------------- GitHub user liyintang opened a pull request: https://github.com/apache/thrift/pull/926 [THRIFT-3714] Define TProtocolException in js/src/thrift.js Define TProtocolException in js/src/thrift.js https://issues.apache.org/jira/browse/THRIFT-3714 You can merge this pull request into a Git repository by running: $ git pull https://github.com/liyintang/thrift liyin/thrift-3714 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/926.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #926 ---- commit 955ba1cd1703aaebd81907e3c992a36db1ac6824 Author: Liyin Tang <liyin.t...@airbnb.com> Date: 2016-03-05T22:54:53Z [THRIFT-3714] Define TProtocolException in js/src/thrift.js ---- > Thrift.TProtocolException is not defined in js/src/thrift.js > ------------------------------------------------------------ > > Key: THRIFT-3714 > URL: https://issues.apache.org/jira/browse/THRIFT-3714 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Compiler > Affects Versions: 0.9.2 > Reporter: Liyin Tang > Attachments: thrift-3714.patch > > > THRIFT-809 will throw new Thrift.TProtocolException if a required field is > missing. However, in the js/src/thrift.js, TProtocolException is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)