[ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192219#comment-15192219 ]
Hudson commented on THRIFT-3737: -------------------------------- SUCCESS: Integrated in Thrift-precommit #303 (See [https://builds.apache.org/job/Thrift-precommit/303/]) Improve isOpen() to give accurate tcp connection status. (THRIFT-3737) (cherrotluo: [https://github.com/apache/thrift/commit/c09968b5ca6e04893059e4799ec8e400b89392d1]) * lib/py/src/transport/TSocket.py > Improve TSocket isOpen() implementation to give more accurate connection > status. > -------------------------------------------------------------------------------- > > Key: THRIFT-3737 > URL: https://issues.apache.org/jira/browse/THRIFT-3737 > Project: Thrift > Issue Type: Bug > Components: Python - Library > Reporter: Cherrot Luo > Labels: patch > Original Estimate: 0h > Remaining Estimate: 0h > > h2. Description > Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true, > even if the underlying TCP connection has been closed or reset by the peer, > unless you manually invoke its close() method. > This is because the isOpen method takes a simple but kind of "irresponsible" > way to judge connection status: > {code:title=TSocket.py} > def isOpen(self): > return self.handle is not None > {code} > This may affect the upstream lib/tools' implementation to offer a *reliable* > transport instance. > For example, in [happybase|https://github.com/wbolster/happybase] (a > developer-friendly Python library to interact with Apache HBase), it use > isOpen() to judge whether it neccessary to reopen the connection in its > [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164] > and connection pool. > h2. Fix > I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945] > The implementation is according to Python's > *[urllib3|https://github.com/shazow/urllib3/blob/0f98217c8125848dd3eded84d11b83c5caefaa97/urllib3/util/connection.py#L13]* > module -- The most widely used Python HTTP library. -- This message was sent by Atlassian JIRA (v6.3.4#6332)