[ 
https://issues.apache.org/jira/browse/THRIFT-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192283#comment-15192283
 ] 

ASF GitHub Bot commented on THRIFT-3739:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/946

    THRIFT-3739 Deprecation warning in codegen/base.d

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3739

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #946
    
----
commit 97f81d508c80a9a0cc2419fbac1a9e29a02dce01
Author: Nobuaki Sukegawa <[email protected]>
Date:   2016-03-13T10:31:14Z

    THRIFT-3739 Deprecation warning in codegen/base.d

----


> Deprecation warning in codegen/base.d
> -------------------------------------
>
>                 Key: THRIFT-3739
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3739
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>    Affects Versions: 0.9.3
>         Environment: dmd 2.070
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Trivial
>
> {quote}
> ../../lib/d/src/thrift/codegen/base.d(502): Deprecation: this is not an lvalue
> {quote}
> https://travis-ci.org/apache/thrift/jobs/113139459#L5997
> It's caused by passing this pointer to "ref" parameter of "readStruct" 
> function.
> Making the parameter to auto ref resolves the problem.
> This should be OK because the readStruct function is for internal use only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to