[
https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203609#comment-15203609
]
ASF GitHub Bot commented on THRIFT-3737:
----------------------------------------
Github user cherrot commented on the pull request:
https://github.com/apache/thrift/pull/945#issuecomment-199073494
A try-except block is surely needed when we do something relative to the
physical world, but we are not discussing on that, right?
>It's perfectly possible without modifying Thrift: just store TSocket
instance and use its handle attribute.
Yes it is possible, but far from perfect: the `TSocket` object is
initialized as a parameter for initializing the `TTransport` instance. Since
`TTransport` does not want me to access the `TSocket` object from it, I have no
responsibility to maintain the socket's state.
Furthermore, if this is not the approach you prefer, then why is there a
`peek` method in C++ lib? If it can be used in the logic of the server side, it
can surely be used in the client side.
> Improve TSocket isOpen() implementation to give more accurate connection
> status.
> --------------------------------------------------------------------------------
>
> Key: THRIFT-3737
> URL: https://issues.apache.org/jira/browse/THRIFT-3737
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Reporter: Cherrot Luo
> Labels: patch
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> h2. Description
> Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true,
> even if the underlying TCP connection has been closed or reset by the peer,
> unless you manually invoke its close() method.
> This is because the isOpen method takes a simple but kind of "irresponsible"
> way to judge connection status:
> {code:title=TSocket.py}
> def isOpen(self):
> return self.handle is not None
> {code}
> This may affect the downstream lib/tools' implementation to offer a
> *reliable* transport instance.
> For example, in [happybase|https://github.com/wbolster/happybase] (a
> developer-friendly Python library to interact with Apache HBase), it use
> isOpen() to judge whether it neccessary to reopen the connection in its
> [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
> and connection pool.
> h2. Fix
> I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
