[ 
https://issues.apache.org/jira/browse/THRIFT-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210549#comment-15210549
 ] 

ASF GitHub Bot commented on THRIFT-3758:
----------------------------------------

GitHub user tpcwang opened a pull request:

    https://github.com/apache/thrift/pull/963

    THRIFT-3758 TApplicationException::getType and TProtocolException::getType 
should be const

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tpcwang/thrift THRIFT-3758

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #963
    
----
commit 1adfae438f7da9196e60311e9186e8eef20b1078
Author: tpcwang <tpc.w...@gmail.com>
Date:   2016-03-24T16:56:10Z

    Changed TApplicationExceptionType and TProtocolExceptionType's getType to 
be const

----


> TApplicationException::getType and TProtocolException::getType should be const
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-3758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3758
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>            Reporter: Ted Wang
>            Priority: Trivial
>
> I can't catch these exceptions by const-reference and then call get_type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to