Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/970#discussion_r57564975
--- Diff: lib/py/src/ext/protocol.tcc ---
@@ -431,6 +433,7 @@ bool ProtocolBase<Impl>::encodeValue(PyObject* value,
TType type, PyObject* type
}
--- End diff --
It shouldn't be...
The value is either null-checked or passed to `Py_INCREF` that does not
accept null.
The intention here is to simply reject too long string values.
If you experienced null value here, we'll need to investigate on that
matter too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
