[
https://issues.apache.org/jira/browse/THRIFT-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221934#comment-15221934
]
ASF GitHub Bot commented on THRIFT-3771:
----------------------------------------
GitHub user tylertreat-wf opened a pull request:
https://github.com/apache/thrift/pull/973
THRIFT-3771 TBufferedTransport gets in invalid state on read/write errors
Go's TBufferedTransport can enter an invalid state after an error occurs
while calling read, write, or flush. This is because TBufferedTransport
uses a bufio.ReadWriter, which "caches" the error returned by a call to
read or write such that subsequent calls return the same error. This can
be problematic if you wish to reuse the transport after a failed read or
write. The solution is to reset the reader/writer on failed calls.
@stevenosborne-wf @markerickson-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tylertreat-wf/thrift THRIFT-3771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #973
----
commit 0b7723664b12ee86c003f76bd19bee722f4bbb7f
Author: Tyler Treat <[email protected]>
Date: 2016-04-01T16:33:20Z
THRIFT-3771 TBufferedTransport gets in invalid state on read/write errors
Go's TBufferedTransport can enter an invalid state after an error occurs
while calling read, write, or flush. This is because TBufferedTransport
uses a bufio.ReadWriter, which "caches" the error returned by a call to
read or write such that subsequent calls return the same error. This can
be problematic if you wish to reuse the transport after a failed read or
write. The solution is to reset the reader/writer on failed calls.
----
> TBufferedTransport gets in invalid state on read/write errors
> -------------------------------------------------------------
>
> Key: THRIFT-3771
> URL: https://issues.apache.org/jira/browse/THRIFT-3771
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Tyler Treat
>
> Go's TBufferedTransport can enter an invalid state after an error occurs
> while calling read, write, or flush. This is because TBufferedTransport uses
> a bufio.ReadWriter, which "caches" the error returned by a call to read or
> write such that subsequent calls return the same error. This can be
> problematic if you wish to reuse the transport after a failed read or write.
> The solution is to reset the reader/writer on failed calls.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
