[ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224434#comment-15224434 ]
ASF GitHub Bot commented on THRIFT-3467: ---------------------------------------- GitHub user creker opened a pull request: https://github.com/apache/thrift/pull/976 THRIFT-3467 Go Maps for Thrift Sets Should Have Values of Type struct{} You can merge this pull request into a Git repository by running: $ git pull https://github.com/creker/thrift THRIFT-3467 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/976.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #976 ---- commit 9c34db83d97952d432ac48e2de59119f81d8475a Author: creker <sam...@yandex.ru> Date: 2016-04-04T16:19:47Z Go Maps for Thrift Sets Should Have Values of Type struct{} ---- > Go Maps for Thrift Sets Should Have Values of Type struct{} > ------------------------------------------------------------ > > Key: THRIFT-3467 > URL: https://issues.apache.org/jira/browse/THRIFT-3467 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler > Affects Versions: 0.9.3 > Reporter: Tom Deering > Labels: golang > > Sets in Thrift are currently turned into maps with boolean values in Go. > Example: > Thrift > {code} > namespace go bug > service FooService{ > void bar (1:set<string> foos) > } > {code} > Go > {code} > func (p *FooServiceClient) Bar(foos map[string]bool) (err error) > {code} > Boolean map values waste memory. Map values should be of the zero-byte > struct{} type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)