[ 
https://issues.apache.org/jira/browse/THRIFT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225229#comment-15225229
 ] 

Aki Sukegawa commented on THRIFT-2342:
--------------------------------------

[~jfarrell] I've already moved relevant changes from 1.0 to 0.10 around two 
weeks ago.
Most of those moved this time were very old and cannot be part of 0.10.0.
Should we just untag Fix Version of them ?

> Add __FILE__ and __LINE__ to Thrift C++ excpetions
> --------------------------------------------------
>
>                 Key: THRIFT-2342
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2342
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler, C++ - Library
>            Reporter: George Godik
>            Assignee: James E. King, III
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10.0
>
>
> Thrift exceptions are somewhat difficult to trace from debug logs. I'd like 
> to add __FILE__AND__LINE__ as a second parameter to some exceptions to make 
> them easier to find.
> For example:
> Every time a required field is not set, the exception that gets generated is 
> a very generic
> throw TProtocolException(TProtocolException::INVALID_DATA)
> see - 
> https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372
> I think I'll start with patching up TProtocolExcpetion in the compiler and if 
> people like this I can make a separate issue and patch for other exceptions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to