Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/977#discussion_r58473050
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.h ---
@@ -20,19 +20,26 @@
#ifndef _THRIFT_SERVER_TTHREADEDSERVER_H_
#define _THRIFT_SERVER_TTHREADEDSERVER_H_ 1
-#include <thrift/concurrency/Monitor.h>
#include <thrift/concurrency/PlatformThreadFactory.h>
#include <thrift/concurrency/Thread.h>
-#include <thrift/server/TServerFramework.h>
+#include <thrift/server/TThreadPoolServer.h>
namespace apache {
namespace thrift {
namespace server {
/**
- * Manage clients using a thread pool.
+ * Manage clients using threads. Once the refactoring for THRIFT-3083
took place it became
+ * obvious that the differences between the two threaded server types was
becoming insignificant.
+ * Therefore to satisfy THRIFT-3096 and fix THRIFT-3768, TThreadedServer
is simply a wrapper
+ * around TThreadedPoolServer now. If backwards compatibility was not a
concern, it would have
+ * been removed.
+ *
+ * The default thread pool size is
*/
-class TThreadedServer : public TServerFramework {
+
+/* [[deprecated]] */
+class TThreadedServer : public TThreadPoolServer {
--- End diff --
I'd suggest using composition and the thread manager internally rather than
inheriting from TThreadPoolServer seeing that TThreadPoolServer exposes other
methods that would defeat the original purpose of the TThreadedServer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
