[ 
https://issues.apache.org/jira/browse/THRIFT-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231752#comment-15231752
 ] 

ASF GitHub Bot commented on THRIFT-3770:
----------------------------------------

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/972#discussion_r58986861
  
    --- Diff: test/tests.json ---
    @@ -268,6 +268,41 @@
         "workdir": "py"
       },
       {
    +    "comment": "Using 'python3' executable with asyncio",
    +    "name": "py3.asyncio",
    +    "server": {
    +      "extra_args": ["TSimpleServer"],
    +      "command": [
    +        "python3",
    +        "TestAsyncioServer.py",
    +        "--verbose",
    +        "--genpydir=gen-py.asyncio"
    +      ]
    +    },
    +    "client": {
    +      "timeout": 10,
    +      "command": [
    +        "python3",
    +        "TestAsyncioClient.py",
    +        "--host=localhost",
    +        "--genpydir=gen-py.asyncio"
    --- End diff --
    
    Can you update test/py/Makefile.am and test/py/generate.cmake so that we 
can easily/automatically run your test with the generated code ?


> Support Python 3.4+ asyncio support
> -----------------------------------
>
>                 Key: THRIFT-3770
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3770
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler, Python - Library
>    Affects Versions: 1.0
>            Reporter: Vadim Markovtsev
>            Priority: Minor
>              Labels: features
>
> Currently, Tornado and Twisted async engines are supported in client lib and 
> the compiler. asyncio is a relatively new engine which is included into 
> Python 3.4+ standard library. It is gaining popularity fast.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to