[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234116#comment-15234116
]
Hudson commented on THRIFT-3768:
--------------------------------
FAILURE: Integrated in Thrift-precommit #403 (See
[https://builds.apache.org/job/Thrift-precommit/403/])
THRIFT-3768: ensure TThreadedServer guarantees the lifetime of the (jim.king:
[https://github.com/apache/thrift/commit/acfa3ea233d4218a39255f434a9bc82ea49353af])
* lib/cpp/src/thrift/server/TThreadedServer.cpp
* lib/cpp/src/thrift/server/TServerFramework.h
* lib/cpp/src/thrift/server/TServerFramework.cpp
* lib/cpp/src/thrift/server/TThreadedServer.h
THRIFT-3768: properly join TThreadedServer threads, added a stress test
(jim.king:
[https://github.com/apache/thrift/commit/a3a1bf86eec1b3f25e16934700154f46526576ae])
* lib/cpp/src/thrift/server/TThreadedServer.h
* lib/cpp/test/TServerIntegrationTest.cpp
* lib/cpp/src/thrift/concurrency/Thread.h
* lib/cpp/src/thrift/server/TThreadedServer.cpp
THRIFT-3768: small maintainability change (jim.king:
[https://github.com/apache/thrift/commit/9410809bb8df7c9742e37c93c0cb4785e2d2de1c])
* lib/cpp/src/thrift/server/TThreadedServer.cpp
> TThreadedServer may crash if it is destroyed immediately after it returns
> from serve(); TThreadedServer disconnects clients when they connec
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3768
> URL: https://issues.apache.org/jira/browse/THRIFT-3768
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: Ted Wang
> Assignee: James E. King, III
> Priority: Minor
>
> Here's a sequence that shows the race:
> Thread-1 (Users of TThreadedServer): Calls TThreadedServer::stop(), which
> calls interruptChildren and initiates the tearing down of client connections.
> Thread-2: In TServerFramework::serve(), broke out of accept, and now blocks
> in TThreadedServer::serve() waiting to drain all the clients.
> Thread-3 (The connected client thread created by TThreadedServer): In
> disposeConnectedClient, running because the server is shutting down and the
> shared_ptr specified this function to be the cleanup function for the client.
> This thread just returned from onClientDisconnected and now context switches.
> Thread-2: TThreadedServer::serve() is notified that all of the clients have
> disconnected and completes.
> Thread-1: Joins on Thread-2 and destroys the server object because it is done.
> Thread-3: Finally gets a chance to run, but now encounters undefined behavior
> because it is still executing a member function of an object that has been
> destroyed.
> You can force this race in action if you put sleep(1) before
> onClientDisconnected() in disposeConnectedClient
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
