Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59390310
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer::serve() {
+ threadFactory_->setDetached(false);
--- End diff --
I could require it to be detached in the constructor and throw an invalid
argument if it is not, I suppose, rather than mutating the thread factory in
serve.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
