Github user jamesreggio commented on a diff in the pull request:
https://github.com/apache/thrift/pull/986#discussion_r59645268
--- Diff: lib/nodejs/lib/thrift/connection.js ---
@@ -181,19 +173,18 @@ Connection.prototype.write = function(data) {
Connection.prototype.connection_gone = function () {
var self = this;
+ this.connected = false;
// If a retry is already in progress, just let that happen
if (this.retry_timer) {
return;
}
- if (!this.max_attempts) {
+ // We cannot reconnect a secure socket.
+ if (!this.max_attempts || this.ssl) {
self.emit("close");
return;
}
- this.connected = false;
- this.ready = false;
--- End diff --
`ready` was unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
