On Thu, Apr 14, 2016 at 9:42 AM, Jake Farrell <[email protected]> wrote:
> Currently the only way for a committer to close a github pull request is to > do so with the commit message. > > I am able to close pull requests because of my root@ karma and having > helped setup git as a service within infra. There are some discussions in > the works to allow more permissions on github for each project, but nothing > definite yet. If there is a list of outdated pull requests I can run > through them and close them out, my primary focus right now is to finish > the blockers and get a 0.10.0 rc out this week > I'm a non-binding -1 on an RC. It seems to me a green CI trumps / is a requirement for a release and both TravisCI and Jenkins are far from green. > > -Jake > > On Thu, Apr 14, 2016 at 10:15 AM, Jim King <[email protected]> > wrote: > > > Project committers should have rights to deny pull requests on github. > > > > - Jim > > > > -----Original Message----- > > From: Jens Geyer [mailto:[email protected]] > > Sent: Thursday, April 14, 2016 3:05 AM > > To: [email protected] > > Subject: AW: 89 pull requests? > > > > Hi, > > > > The backlog is on Github, I think that's enough. That's not the main > issue > > here. > > > > Unfortunately only a few of us are allowed to close them if they are > > irrelevant or the like. If the original author does not follow up, e.g. I > > can't do that either. IIRC Jake can. > > > > And tgere are a few that should be merged, but just as an example, my > > Haskell skills are very limited, thus I am not going to do anything about > > such stuff that has a certain complexity. > > > > Have fun, > > JensG > > ________________________________ > > Von: Jim King > > Gesendet: 14.04.2016 06:57 > > An: [email protected] > > Betreff: 89 pull requests? > > > > There are a lot of pull requests open against the thrift project, some > > going back to 2014. > > I suspect a bunch of the pull requests in there may be for issues merged, > > but not auto-closed. > > I'd like to recommend that any pull request that's open for more than a > > month and has been idle for as long is closed. The author can re-submit > it. > > We need to keep the backlog of pull requests to something more > manageable. > > > > [Description: Description: simplivity-lg-xsmall] James E. King, III > > Architect > > 8 Technology Drive, 2nd Floor > > Westborough, MA 01581-1756 > > Ph: 855-SVT-INFO > > > > > --------------------------------------------------------------------------------------- > > PRIVACY STATEMENT: > > This message is a PRIVATE communication. This message and all > attachments > > are a private communication sent by SimpliVity and are considered to be > > confidential or protected by privilege. If you are not the intended > > recipient, you are hereby notified that any disclosure, copying, > > distribution or use of the information contained in or attached to this > > message is strictly prohibited. Please notify the sender of the delivery > > error by replying to this message, and then delete it from your system. > > > > > --------------------------------------------------------------------------------------- > > > > > --------------------------------------------------------------------------------------- > > PRIVACY STATEMENT: > > This message is a PRIVATE communication. This message and all > attachments > > are a private communication sent by SimpliVity and are considered to be > > confidential or protected by privilege. If you are not the intended > > recipient, you are hereby notified that any disclosure, copying, > > distribution or use of the information contained in or attached to this > > message is strictly prohibited. Please notify the sender of the delivery > > error by replying to this message, and then delete it from your system. > > > > > --------------------------------------------------------------------------------------- > > >
